Log payload when processing webhooks #1114
Conversation
|
There is already an issue in JIRA about this and a PR that add logs to understand where the webhook processing and/or generated event could be lost. |
Should those logs be added in a release? Would likely allow for more people to easily pick up such changes and assist with the debugging effort. |
|
No there are only to debug a specific issue |
Without such logs users would have a hard time being able to have any visibility into the webhook processing. I've commented in #1105 on the difficulty of trying to diagnose any such issue. IMO it would be helpful to keep such logs perhaps on the |
|
PR #1121 should cover any case about webhook processor phase |
2 participants
Hey @nfalco79 I'm using this PR as a springboard to start a discussion on debuggability. I've recently had issues with understanding why builds are not triggered and currently its impossible to figure out if a webhook is being processed with what payload and is a build even triggered and if not why isn't a build triggered.
It seems like restarting jenkins in some cases fixes the issue of builds being triggered but perhaps its better for us to get an understanding as to why this happens and we can avoid having such restarts.
Your checklist for this pull request